[PATCH] D141712: [GVN] Improve PRE on load instructions

Tue May 30 12:23:45 PDT 2023

nickdesaulniers added a comment.

In D141712#4377041 <https://reviews.llvm.org/D141712#4377041>, @Carrot wrote:

> Updated the function replaceValuesPerBlockEntry to replace all OldLoad with NewLoad. So the deleted OldLoad instruction will not be used by later PHI instruction.
>
> @TimNN, @antmo, @nickdesaulniers, @maxim-kuvyrkov could you help to test if this version work for you?
>
> thanks

Sorry, before even being able to test the new patch, I'm running into numerous regressions that I need to sort out first:

1. https://github.com/ClangBuiltLinux/linux/issues/1855
2. https://github.com/ClangBuiltLinux/linux/issues/1856
3. https://github.com/ClangBuiltLinux/linux/issues/1857

It's unusual to have that many regressions over the weekend, but may we please have some time to resolve those so that we can re-test this patch properly (before you resubmit)?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141712/new/

https://reviews.llvm.org/D141712