[PATCH] D151276: Weaken MFI Max Call Frame Size Assertion

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 11:05:47 PDT 2023


MatzeB added a comment.

> In this case AdjustsStack on line 352 should be initialized to false and MFI.adjustsStack() == AdjustsStack should also be removed making this assertion kind of useless.

If @MatzeB is happy with this, I'm too.

Maybe we can handle this in a similar manner. `AdjustsStack==true` should be the more conservative answer and we should be fine going from an initial `true` to `false` after optimizations. So we can weaken this check as well to only assert that we are not going from `false` to `true`...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151276/new/

https://reviews.llvm.org/D151276



More information about the llvm-commits mailing list