[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:248
+  auto ISAVer = llvm::AMDGPU::getIsaVersion(Opts.CPU);
+  HasImage = ISAVer.Major != 9 || ISAVer.Minor != 4;
 }
----------------
My usual nit about negations: `!(ISAVer.Major == 9 && ISAVer.Minor == 4)` is easier to read.

Is ISA 9.4 the only version w/o image support? Or should it be a range comparison instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151349/new/

https://reviews.llvm.org/D151349