[PATCH] D151602: [TableGen] Add !getdagarg and !getdagname

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 09:14:42 PDT 2023


hliao added inline comments.


================
Comment at: llvm/lib/TableGen/TGLexer.h:53
+  equal,
+  question,  // = ?
+  paste,     // #
----------------
simon_tatham wrote:
> It isn't clear why this section had to be reformatted at all in this patch, but if you //are// going to put each enum entry on its own line, you could at least break up the comments in the same way so that each one has a comment with its own symbol.
The pre-merge check fails now once clang-format generates different changes from my original change cause we add `XDagGetArg` and `XDagGetName`. I could revert that part of change or make such formatting NFC change in advance before this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151602/new/

https://reviews.llvm.org/D151602



More information about the llvm-commits mailing list