[PATCH] D32198: [TySan] A Type Sanitizer (LLVM)

[Russell Gallop via Phabricator via llvm-commits]

russell.gallop added inline comments.


================
Comment at: include/llvm/Bitcode/LLVMBitCodes.h:563
   ATTR_KIND_STRICT_FP = 54,
+  ATTR_KIND_SANITIZE_TYPE = 55
 };
----------------
fhahn wrote:
> russell.gallop wrote:
> > Something looks like it's gone wrong with the diff here:
> > a) It looks like this is removing TySan not adding it, ditto some (but not all) of the other changes below
> > b) As of today I think we're up to 87 attribute kinds [1] so I don't think that this has picked everything up correctly.
> > 
> > [1] https://github.com/llvm/llvm-project/blob/9ec52275acd6120db9a33d4f97d28848166cf839/llvm/include/llvm/Bitcode/LLVMBitCodes.h#L715
> Is it possible you are not looking at the latest version of the diff when you submitted the comment? 
> 
> 
> There's an `ID` of an old version of the diff in the URL to the comment. In the latest version of the diff has ` ATTR_KIND_SANITIZE_TYPE = 88` here.
Ah, I think that must have been it, sorry. It looks okay now. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32198/new/

https://reviews.llvm.org/D32198