[PATCH] D151694: [InstCombine] Add test case for (icmp eq A, -1) & (icmp eq B, -1) --> (icmp eq (A&B), -1); NFC

Tue May 30 03:33:00 PDT 2023

fhahn added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/pr62311.ll:3
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+; RUN: opt < %s -passes='default<O3>' -S | FileCheck --check-prefix INTEGRATED %s
+;
----------------
I don't think we should run `O3` here. `llvm/test/Transforms/PhaseOrdering` is the place to check for pass interactions in the default pipeline.

================
Comment at: llvm/test/Transforms/InstCombine/pr62311.ll:17
+; Function Attrs: mustprogress nounwind uwtable
+define dso_local noundef zeroext i1 @_Z7allonesandwithequalDv8_x(<8 x i64> noundef %x) local_unnamed_addr #0 {
+; CHECK-LABEL: @_Z7allonesandwithequalDv8_x(
----------------
nit: remove unneeded `local_unnamed_addr #0`, `dso_local` and C++ name mangling for the function name. The test with O3 will likely need an x86 target triple.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151694/new/

https://reviews.llvm.org/D151694