[PATCH] D151023: [llvm-exegesis] Add Target Memory Utility Functions

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 02:59:52 PDT 2023


courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/Target.cpp:978
 
+#ifdef __linux__
+std::vector<MCInst> ExegesisX86Target::generateLowerMunmap() const {
----------------
All these are extremely complex. Can't we insert a call to a separate module instead ?

Given that we don't actually care about measuring the setup code, we don't need to inline  each function here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151023/new/

https://reviews.llvm.org/D151023



More information about the llvm-commits mailing list