[PATCH] D138135: [lld][ELF] Support LoongArch

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 29 19:47:38 PDT 2023


xen0n marked an inline comment as done.
xen0n added inline comments.


================
Comment at: lld/ELF/Arch/LoongArch.cpp:418
+  case R_LARCH_GOT64_PC_LO20:
+  case R_LARCH_GOT64_PC_HI12:
+    return R_LOONGARCH_GOT_PAGE_PC;
----------------
MQ-mengqing wrote:
> Since TLS_GD also uses GOT64_PC_{HI20, LO12}, it may have something mistake.
Thanks for pointing out that; seems I've heavily underestimated the amount of reuse happening! I've just unified about as much TLS logic as possible into the existing GOT case (although I don't have time to write the tests until late night).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138135/new/

https://reviews.llvm.org/D138135



More information about the llvm-commits mailing list