[PATCH] D151652: [ms-inline asm] Add error check for `getAsInteger`
Phoebe Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 29 18:18:23 PDT 2023
pengfei added a comment.
In D151652#4379594 <https://reviews.llvm.org/D151652#4379594>, @skan wrote:
> Add a test?
I don't think it's necessary to check each negative inputs, especially we don't have actual problem with this. This was just found by static analyze tool.
We even don't have a test when the functionality was introduced rG5dcb4664f276 <https://reviews.llvm.org/rG5dcb4664f27630f88bdd12ca5dd6b7264998d749>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151652/new/
https://reviews.llvm.org/D151652
More information about the llvm-commits
mailing list