[PATCH] D151640: [LSV] Attempt to fix comparison of APInt's with different bit widths.
Justin Lebar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 29 08:44:19 PDT 2023
jlebar added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:1302
+ // have the same datatype. But we seem to be hitting this in practice.
+ if (FalseDiff.has_value() &&
+ TrueDiff->getBitWidth() == FalseDiff->getBitWidth() &&
----------------
tschuett wrote:
> Drive-by nit. `.has_value()`should only be in unit tests. The `.has_value()` is redundant in this case.
Didn't end up using this; removed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151640/new/
https://reviews.llvm.org/D151640
More information about the llvm-commits
mailing list