[PATCH] D149404: [ValueTracking][InstCombine] Add a new API to allow to ignore poison generating flags or metadatas when implying poison

Mon May 29 07:47:00 PDT 2023

fhahn added a comment.

In D149404#4377682 <https://reviews.llvm.org/D149404#4377682>, @StephenFan wrote:

> In D149404#4376971 <https://reviews.llvm.org/D149404#4376971>, @nikic wrote:
>
>> I would be okay with reverting the change. I don't think we had particularly strong motivation for it (iirc it was basically just that some selects were not converted, without actually blocking any following optimizations), so if it causes regressions in practice, it's probably best to not do it. Our optimizations for logical and/or are pretty good.
>
> What about just handling poison generating metadata?

I went ahead and reverted the change for now. I am not sure, but I would assume dropping poison generating metadata could lead to similarly missed optimizations unfortunately.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149404/new/

https://reviews.llvm.org/D149404