[PATCH] D151648: [IPSCCP] Make sure Post Dominator Tree always is updated

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 29 06:54:44 PDT 2023


bjope added reviewers: aeubanks, nikic.
bjope added a comment.
Herald added a subscriber: StephenFan.

I have no clue if this messes up things (considering the compile-time measurements done for the related patches to IPSCCP/FunctionSpecialization). But I prefer if things are slow rather than faulty.

We've seen at least three different crashes/asserts in downstream testing due to this problem (probably with non-standard pipelines in fuzzy testing, so it is a bit annoying to leave this unfixed.

Looking at the impacted test cases it seems like PostDominatorTree isn't always available at beginning of IPSCCP even with default pipelines, so maybe the bug could manifest also with default pipelines(?).).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151648/new/

https://reviews.llvm.org/D151648



More information about the llvm-commits mailing list