[PATCH] D151596: [RISCV] Teach performCombineVMergeAndVOps to handle instructions FMA instructions.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 29 01:50:19 PDT 2023


frasercrmck accepted this revision.
frasercrmck added a comment.

LGTM



================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:3303
   // The vector policy operand may be present for masked intrinsics
-  bool HasVecPolicyOp = RISCVII::hasVecPolicyOp(TrueTSFlags);
   unsigned TrueVLIndex =
----------------
Was this moved just to keep the "HasOp" checks together? I don't mind the change - just asking in case it was part of an earlier diff that got refactored.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vfwmacc-vp.ll:57
+; FIXME: Support this case?
+define <vscale x 1 x float> @vfmacc_vv_nxv1f32_masked__tu(<vscale x 1 x half> %a, <vscale x 1 x half> %b, <vscale x 1 x float> %c, <vscale x 1 x i1> %m, i32 zeroext %evl) {
+; CHECK-LABEL: vfmacc_vv_nxv1f32_masked__tu:
----------------
Double underscore in function name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151596/new/

https://reviews.llvm.org/D151596



More information about the llvm-commits mailing list