[PATCH] D150522: [LoongArch] Support CodeModel::Large codegen

[Lu Weining via Phabricator via llvm-commits]

SixWeining accepted this revision.
SixWeining added a comment.
This revision is now accepted and ready to land.

Thanks. LGTM with some nits.



================
Comment at: llvm/lib/Target/LoongArch/LoongArchExpandPseudoInsts.cpp:266
+          .addReg(TmpPart0,
+                  RegState::Kill); // "rj" is needed due to InstrInfo pattern
+  auto Part3 = BuildMI(MBB, MBBI, DL, TII->get(LoongArch::LU52I_D), TmpParts023)
----------------
It's better to use complete sentence.


================
Comment at: llvm/lib/Target/LoongArch/LoongArchExpandPseudoInsts.cpp:362
+  if (Large) {
+    Register Part012 =
+        MF->getRegInfo().createVirtualRegister(&LoongArch::GPRRegClass);
----------------
Do you mean `Parts012` ?


================
Comment at: llvm/lib/Target/LoongArch/LoongArchExpandPseudoInsts.cpp:367
+        .addReg(Parts01,
+                RegState::Kill) // "rj" is needed due to InstrInfo pattern
+        .addDisp(Symbol, 0, LoongArchII::MO_LE64_LO);
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150522/new/

https://reviews.llvm.org/D150522