[PATCH] D151640: [LSV] Attempt to fix comparison of APInt's with different bit widths.

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 28 23:09:21 PDT 2023


tschuett added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:1302
+      // have the same datatype.  But we seem to be hitting this in practice.
+      if (FalseDiff.has_value() &&
+          TrueDiff->getBitWidth() == FalseDiff->getBitWidth() &&
----------------
Drive-by nit. `.has_value()`should only be in unit tests. The `.has_value()` is redundant in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151640/new/

https://reviews.llvm.org/D151640



More information about the llvm-commits mailing list