[PATCH] D145163: Add support for vectorization of interleaved memory accesses for scalable VF

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 28 11:30:01 PDT 2023


fhahn added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14742
 
+  if (EC.isScalable()) {
+    if (MinElts * ElSize == 128)
----------------
Nit: can just return the condition 


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:458
+  if (VecTy->isScalableTy()) {
+    assert(Factor == 2 && "Unsupported interleave factor for scalable vectors");
+    VectorType *WideVecTy = VectorType::getDoubleElementsVectorType(VecTy);
----------------
Should we have this assert already when constructing the interleave recipe?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145163/new/

https://reviews.llvm.org/D145163



More information about the llvm-commits mailing list