[PATCH] D151630: [LSV] Fix the ContextInst for computeKnownBits.

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 28 07:56:35 PDT 2023


jlebar created this revision.
jlebar added a reviewer: ronlieb.
Herald added subscribers: foad, kerbowa, hiraditya, jvesely.
Herald added a project: All.
jlebar requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead.
Herald added a project: LLVM.

Previously we used the later of GEPA or GEPB.  This is hacky because
really we should be using the later of the two load/store instructions
being considered.  But also it's flat-out incorrect, because GEPA and
GEPB might be in different BBs, in which case we cannot ask which one
comes last (assertion failure,
https://reviews.llvm.org/D149893#4378332).

Fixed, now we use the correct context instruction.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151630

Files:
  llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
  llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/gep-bitcast.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151630.526330.patch
Type: text/x-patch
Size: 6467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230528/5038eda0/attachment.bin>


More information about the llvm-commits mailing list