[llvm] 65f40cb - [ModuleInliner] Remove an inapplicable comment

[Kazu Hirata via llvm-commits]

Author: Kazu Hirata
Date: 2023-05-27T22:26:37-07:00
New Revision: 65f40cb455f8eaf83c163793d19640b56393c1e5

URL: https://github.com/llvm/llvm-project/commit/65f40cb455f8eaf83c163793d19640b56393c1e5
DIFF: https://github.com/llvm/llvm-project/commit/65f40cb455f8eaf83c163793d19640b56393c1e5.diff

LOG: [ModuleInliner] Remove an inapplicable comment

The module inliner has its own logic in deciding the order in which
call sites are inlined, so the comment is inapplicable.

Added: 
    

Modified: 
    llvm/lib/Transforms/IPO/ModuleInliner.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/IPO/ModuleInliner.cpp b/llvm/lib/Transforms/IPO/ModuleInliner.cpp
index 71ef3b4f3e209..5e91ab80d7505 100644
--- a/llvm/lib/Transforms/IPO/ModuleInliner.cpp
+++ b/llvm/lib/Transforms/IPO/ModuleInliner.cpp
@@ -144,11 +144,6 @@ PreservedAnalyses ModuleInlinerPass::run(Module &M,
   // Populate the initial list of calls in this module.
   for (Function &F : M) {
     auto &ORE = FAM.getResult<OptimizationRemarkEmitterAnalysis>(F);
-    // We want to generally process call sites top-down in order for
-    // simplifications stemming from replacing the call with the returned value
-    // after inlining to be visible to subsequent inlining decisions.
-    // FIXME: Using instructions sequence is a really bad way to do this.
-    // Instead we should do an actual RPO walk of the function body.
     for (Instruction &I : instructions(F))
       if (auto *CB = dyn_cast<CallBase>(&I))
         if (Function *Callee = CB->getCalledFunction()) {