[PATCH] D151394: [LSR] Treat URem as uninteresting

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I think what I still don't really understand is why LSR thinks it is safe to replace the IV here when it isn't. It seems like marking the urem as interesting here may be non-profitable, but also shouldn't be incorrect. I think there has to be some bug on the LSR side to enable this replacement.

Note that `urem` is not the only non-add instruction that can end up producing an add SCEV node, so I'm not sure why we need to treat urem in particular specially.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151394/new/

https://reviews.llvm.org/D151394