[PATCH] D149404: [ValueTracking][InstCombine] Add a new API to allow to ignore poison generating flags or metadatas when implying poison
luxufan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 27 00:46:53 PDT 2023
StephenFan added a comment.
In D149404#4376971 <https://reviews.llvm.org/D149404#4376971>, @nikic wrote:
> I would be okay with reverting the change. I don't think we had particularly strong motivation for it (iirc it was basically just that some selects were not converted, without actually blocking any following optimizations), so if it causes regressions in practice, it's probably best to not do it. Our optimizations for logical and/or are pretty good.
What about just handling poison generating metadata?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149404/new/
https://reviews.llvm.org/D149404
More information about the llvm-commits
mailing list