[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 15:51:42 PDT 2023
tejohnson added inline comments.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:995
+ // TODO: Consider passing the MemoryProfileOutput to the pass builder via
+ // the PGOOptions, and set this up there.
----------------
vitalybuka wrote:
> tejohnson wrote:
> > vitalybuka wrote:
> > > if this is registerOptimizerLastEPCallback, it can be next to other sanitizers, in addSanitizers()
> > It could be, but while it uses the sanitizer common support, it isn't logically a sanitizer. Is there an advantage to setting it up there?
> no advantages.
> it has runtime similar to sanitizer, so I rather thing about this as sanitizer :)
>
Ok thanks. I think I would prefer to keep it separate, and hopefully soon address the TODO here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151593/new/
https://reviews.llvm.org/D151593
More information about the llvm-commits
mailing list