[PATCH] D148915: [TableGen] Introduce function and lambda

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/include/llvm/TableGen/Record.h:1724
+
+  static std::string ReturnValueName;
+
----------------
We don't seem to set it anywhere to anything other than `__return__`.
Can we just return the right name from getReturnValueName() directly:
```
StringInit *getReturnValueName() const {
    return StringInit::get(getRecords(), "__return__");
  }
```


================
Comment at: llvm/lib/TableGen/Record.cpp:2832
 
+std::string Record::ReturnValueName = "__return__";
+
----------------
craig.topper wrote:
> Why does this need to be a std::string?
We may not need it at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148915/new/

https://reviews.llvm.org/D148915