[PATCH] D151579: Fix -u option in dsymutil, to not emit an extra DW_LNE_set_address if the original line table was empty
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 14:18:29 PDT 2023
JDevlieghere added inline comments.
================
Comment at: llvm/lib/DWARFLinker/DWARFStreamer.cpp:854-855
- if (LineTable.Rows.empty()) {
+ if (LineTable.Rows.empty() ||
+ (LineTable.Rows.size() == 1 && LineTable.Rows[0].EndSequence)) {
// We only have the dummy entry, dsymutil emits an entry with a 0
----------------
Would it make sense to hoist that into the `LineTable` class and have a method `LineTable::empty()` that returns exactly this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151579/new/
https://reviews.llvm.org/D151579
More information about the llvm-commits
mailing list