[PATCH] D32198: [TySan] A Type Sanitizer (LLVM)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 12:47:20 PDT 2023


fhahn updated this revision to Diff 526162.
fhahn added a comment.

Rebased.

In D32198#4256738 <https://reviews.llvm.org/D32198#4256738>, @leonardchan wrote:

> In D32198#4171275 <https://reviews.llvm.org/D32198#4171275>, @fhahn wrote:
>
>> Address outstanding comments, remove some leftover commented-out code.
>>
>> In D32198#4162521 <https://reviews.llvm.org/D32198#4162521>, @leonardchan wrote:
>>
>>> In D32198#3929026 <https://reviews.llvm.org/D32198#3929026>, @fhahn wrote:
>>>
>>>> Commandeering after the recent updates to make review + follow-ups easier.
>>>
>>> @fhahn are there any updates with landing this? Is there any way I could help speed things up?
>>
>> The main things are help with reviewing the LLVM part (this patch) and testing the runtime part on different platforms (Linux x86/AArch64 if possible). I can do testing on macOS x86/ARM64.
>
> Thanks. I've tested this patch alone on both linux x86 and aarch64 and can confirm they pass. I'll check the other ones next. Do you just need a rubber stamp lgtm on this patch?

I'd appreciate a review, possibly slightly more than a rubber stamp :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32198/new/

https://reviews.llvm.org/D32198

Files:
  llvm/include/llvm/Bitcode/LLVMBitCodes.h
  llvm/include/llvm/IR/Attributes.td
  llvm/include/llvm/Transforms/Instrumentation/TypeSanitizer.h
  llvm/lib/Analysis/TypeBasedAliasAnalysis.cpp
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/CodeGen/ShrinkWrap.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/Instrumentation/CMakeLists.txt
  llvm/lib/Transforms/Instrumentation/TypeSanitizer.cpp
  llvm/lib/Transforms/Utils/CodeExtractor.cpp
  llvm/test/Instrumentation/TypeSanitizer/access-with-offfset.ll
  llvm/test/Instrumentation/TypeSanitizer/alloca.ll
  llvm/test/Instrumentation/TypeSanitizer/anon.ll
  llvm/test/Instrumentation/TypeSanitizer/basic-nosan.ll
  llvm/test/Instrumentation/TypeSanitizer/basic.ll
  llvm/test/Instrumentation/TypeSanitizer/byval.ll
  llvm/test/Instrumentation/TypeSanitizer/globals.ll
  llvm/test/Instrumentation/TypeSanitizer/invalid-metadata.ll
  llvm/test/Instrumentation/TypeSanitizer/memintrinsics.ll
  llvm/test/Instrumentation/TypeSanitizer/nosanitize.ll
  llvm/test/Instrumentation/TypeSanitizer/sanitize-no-tbaa.ll
  llvm/test/Instrumentation/TypeSanitizer/swifterror.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32198.526162.patch
Type: text/x-patch
Size: 115944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230526/ca710f43/attachment.bin>


More information about the llvm-commits mailing list