[PATCH] D151579: Fix -u option in dsymutil, to not emit an extra DW_LNE_set_address if the original line table was empty

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham created this revision.
rastogishubham added reviewers: aprantl, JDevlieghere, avl.
rastogishubham added a project: debug-info.
Herald added subscribers: ormris, hiraditya.
Herald added a project: All.
rastogishubham requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, jplehr, sstefan1.
Herald added a project: LLVM.

With dsymutil's -u option, only the accelerator tables should be updated, but with https://reviews.llvm.org/D150554 the -u option will still re-generate the line table. If the line table was empty, that is, it was a dummy line table, with no entries in it, dsymutil will always generate a line table with a DW_LNE_end_sequence, a funky side effect of this is that when the line table is re-generated, it will always emit a DW_LNE_set_address first, which will change the line table total size. This patch addresses this by making sure that if all the line table has in it is a DW_LNE_end_sequence, it is the same as a dummy entry.


https://reviews.llvm.org/D151579

Files:
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/test/tools/dsymutil/ARM/fat-dylib-update.test
  llvm/tools/dsymutil/dsymutil.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151579.526153.patch
Type: text/x-patch
Size: 7625 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230526/57544ecb/attachment.bin>