[PATCH] D151568: [PseudoProbe] Do not force the calliste debug loc to inlined probes from __nodebug__ functions.
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 11:23:16 PDT 2023
hoy added a comment.
In D151568#4376679 <https://reviews.llvm.org/D151568#4376679>, @wenlei wrote:
>> For pseudo probes we would like to keep their original debug location
>
> Is this accurate? we just don't want to have non-zero discriminator for probes, but we don't really care about whether their debug metadata point to original debug location or not. In this particular case, there's just no need to fill in call debug info if probe from inlinee originally doesn't have debug info.
Yeah, would be more accurate to say "keep their original dwarf discriminator".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151568/new/
https://reviews.llvm.org/D151568
More information about the llvm-commits
mailing list