[PATCH] D150375: [FuncSpec] Replace LoopInfo with BlockFrequencyInfo.
Bjorn Pettersson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 08:43:47 PDT 2023
bjope added a comment.
So to summarize what I think is going on (more or less by just looking at the code, I haven't been running it in a debugger):
1. When setting up the DomTreeUpdater the use of `FAM.getCachedResult<PostDominatorTreeAnalysis>(F)` might result in not finding any cached PDT. So the DomTreeUpdater will not update PDT.
2. But then as a side-effect of using BlockFrequencyAnalysis a PDT is created an calculated.
3. Optimizations are done, without updating the now existing PDT.
4. The pass says that PDT is preserved. But it has not been updated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150375/new/
https://reviews.llvm.org/D150375
More information about the llvm-commits
mailing list