[llvm] a1dec5d - [ValueTracking] Avoid optimizing away condition in test (NFC)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 07:38:45 PDT 2023
Author: Nikita Popov
Date: 2023-05-26T16:38:37+02:00
New Revision: a1dec5dacbef2635d2de6533ba7cf686a78ca674
URL: https://github.com/llvm/llvm-project/commit/a1dec5dacbef2635d2de6533ba7cf686a78ca674
DIFF: https://github.com/llvm/llvm-project/commit/a1dec5dacbef2635d2de6533ba7cf686a78ca674.diff
LOG: [ValueTracking] Avoid optimizing away condition in test (NFC)
This is not what we're interested in testing, and it allows to
essentially optimize away the entire function with more powerful
optimization.
Added:
Modified:
llvm/test/Analysis/ValueTracking/known-power-of-two-urem.ll
Removed:
################################################################################
diff --git a/llvm/test/Analysis/ValueTracking/known-power-of-two-urem.ll b/llvm/test/Analysis/ValueTracking/known-power-of-two-urem.ll
index b7c46654e7f7..eaf16ce2ea49 100644
--- a/llvm/test/Analysis/ValueTracking/known-power-of-two-urem.ll
+++ b/llvm/test/Analysis/ValueTracking/known-power-of-two-urem.ll
@@ -299,7 +299,8 @@ define i64 @known_power_of_two_urem_loop_ashr_negative(i64 %size, i64 %a) {
; CHECK-NEXT: [[UREM:%.*]] = urem i64 [[SIZE:%.*]], [[PHI]]
; CHECK-NEXT: [[ADD]] = add nsw i64 [[SUM]], [[UREM]]
; CHECK-NEXT: [[I]] = ashr i64 [[PHI]], [[A:%.*]]
-; CHECK-NEXT: br i1 true, label [[FOR_BODY]], label [[FOR_END:%.*]]
+; CHECK-NEXT: [[ICMP:%.*]] = icmp ugt i64 [[I]], 1
+; CHECK-NEXT: br i1 [[ICMP]], label [[FOR_BODY]], label [[FOR_END:%.*]]
; CHECK: for.end:
; CHECK-NEXT: ret i64 [[SUM]]
;
@@ -312,7 +313,7 @@ for.body:
%urem = urem i64 %size, %phi
%add = add nsw i64 %sum, %urem
%i = ashr i64 %phi, %a
- %icmp = icmp ugt i64 %i, 0
+ %icmp = icmp ugt i64 %i, 1
br i1 %icmp, label %for.body, label %for.end
for.end:
@@ -371,7 +372,8 @@ define i64 @known_power_of_two_urem_loop_negative(i64 %size, i64 %a) {
; CHECK-NEXT: [[UREM:%.*]] = urem i64 [[SIZE:%.*]], [[PHI]]
; CHECK-NEXT: [[ADD]] = add nuw i64 [[SUM]], [[UREM]]
; CHECK-NEXT: [[I]] = add nuw i64 [[PHI]], 1
-; CHECK-NEXT: br i1 true, label [[FOR_BODY]], label [[FOR_END:%.*]]
+; CHECK-NEXT: [[ICMP:%.*]] = icmp ugt i64 [[PHI]], 1
+; CHECK-NEXT: br i1 [[ICMP]], label [[FOR_BODY]], label [[FOR_END:%.*]]
; CHECK: for.end:
; CHECK-NEXT: ret i64 [[SUM]]
;
@@ -385,7 +387,7 @@ for.body:
%urem = urem i64 %size, %phi
%add = add nuw i64 %sum, %urem
%i = add nuw i64 %phi, 1
- %icmp = icmp ugt i64 %i, 0
+ %icmp = icmp ugt i64 %i, 2
br i1 %icmp, label %for.body, label %for.end
for.end:
More information about the llvm-commits
mailing list