[PATCH] D151535: [X86] fold select to mask instructions.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:20028
 static bool canCombineAsMaskOperation(SDValue V1, SDValue V2,
                                       const X86Subtarget &Subtarget) {
   if (!Subtarget.hasAVX512())
----------------
RKSimon wrote:
> Do we actually need canCombineAsMaskOperation to take 2 input operands? Its other use in lowerVECTOR_SHUFFLE looks like it could be split to call it twice.
Taking 1 input operand looks better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151535/new/

https://reviews.llvm.org/D151535