[PATCH] D151552: [compiler-rt] Refactor memintrinsic interceptors

Marco Elver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 03:32:08 PDT 2023


melver created this revision.
melver added reviewers: vitalybuka, dvyukov.
Herald added subscribers: Enna1, dberris.
Herald added a project: All.
melver requested review of this revision.
Herald added projects: Sanitizers, LLVM.
Herald added subscribers: llvm-commits, Sanitizers.

This moves memintrinsic interceptors (memcpy/memmove/memset) into a new
file sanitizer_common_interceptors_memintrinsics.inc.

This is in preparation of redefining builtins, however, we must be
careful to not redefine builtins in TUs that define interceptors of the
same name.

In all cases except for MSan, memintrinsic interceptors were moved to a
new TU $tool_interceptors_memintrinsics.cpp. In the case of MSan, it
turns out this is not yet necessary (as shown by the later patch
introducing memcpy tests).

NFC.

Depends on D151551 <https://reviews.llvm.org/D151551>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151552

Files:
  compiler-rt/lib/asan/asan_interceptors.cpp
  compiler-rt/lib/asan/asan_interceptors.h
  compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp
  compiler-rt/lib/asan/asan_interceptors_memintrinsics.h
  compiler-rt/lib/hwasan/hwasan_interceptors.cpp
  compiler-rt/lib/memprof/memprof_interceptors.cpp
  compiler-rt/lib/memprof/memprof_interceptors.h
  compiler-rt/lib/memprof/memprof_interceptors_memintrinsics.cpp
  compiler-rt/lib/memprof/memprof_interceptors_memintrinsics.h
  compiler-rt/lib/msan/msan_interceptors.cpp
  compiler-rt/lib/sanitizer_common/CMakeLists.txt
  compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
  compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_memintrinsics.inc
  compiler-rt/lib/tsan/rtl/CMakeLists.txt
  compiler-rt/lib/tsan/rtl/tsan_interceptors.h
  compiler-rt/lib/tsan/rtl/tsan_interceptors_memintrinsics.cpp
  compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
  compiler-rt/lib/tsan/rtl/tsan_report.cpp
  llvm/utils/gn/secondary/compiler-rt/lib/tsan/rtl/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151552.526010.patch
Type: text/x-patch
Size: 45400 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230526/bc040800/attachment.bin>


More information about the llvm-commits mailing list