[PATCH] D134599: [RISCV] Readjusting the framestack for Zcmp

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:1378
+      for (unsigned i = 0; i < PushPopRegs; i++)
+        PushBuilder.addDef(AllPopRegs[i], RegState::Implicit);
+    }
----------------
`CM.PUSH` does "use" the callee save. I think you should use `addUse` instead of `addDef`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134599/new/

https://reviews.llvm.org/D134599