[PATCH] D151313: [RISCV][BF16] Make backend type bf16 to follow the psABI
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 25 22:43:08 PDT 2023
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2437
+ SelectionDAG &DAG) const {
+ SDLoc DL(Op);
+ SDValue Op0;
----------------
craig.topper wrote:
> This is an incorrect conversion. We can't truncate the mantissa. It would turn some nan encodings into infinity. Probably other issues I haven't thought of yet.
We need to use `truncsfbf2`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151313/new/
https://reviews.llvm.org/D151313
More information about the llvm-commits
mailing list