[PATCH] D148915: [TableGen] Introduce function and lambda

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/TableGen/Record.h:1628
   SMLoc Loc; // Source location of definition of name.
-  PointerIntPair<RecTy *, 2, FieldKind> TyAndKind;
+  PointerIntPair<RecTy *, 3, FieldKind> TyAndKind;
   Init *Value;
----------------
Are there 3 available bits on a 32-bit host?


================
Comment at: llvm/lib/TableGen/Record.cpp:2832
 
+std::string Record::ReturnValueName = "__return__";
+
----------------
Why does this need to be a std::string?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148915/new/

https://reviews.llvm.org/D148915