[PATCH] D147763: [ARM] Emit code alignment after .arm and .thumb directives
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 25 19:41:59 PDT 2023
MaskRay added inline comments.
================
Comment at: lld/test/ELF/arm-fix-cortex-a8-nopatch.s:92
-// CALLSITE5: 00025ffe <source5>:
-// CALLSITE5-NEXT: 25ffe: beq.w 0x25ffa <target5>
+// CALLSITE5: 00026000 <source5>:
+// CALLSITE5-NEXT: 26000: beq.w 0x25ffa <target5>
----------------
MaskRay wrote:
> This address adjustment will break what the test wants to check. The tests need a proper update.
>
> @peter.smith
With this change, the test will pass even if I remove `--fix-cortex-a8`. This means the directive semantics change nullifies the purpose of the test. I think we should repair the test properly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147763/new/
https://reviews.llvm.org/D147763
More information about the llvm-commits
mailing list