[PATCH] D147783: [VPlan] Add stride->constant VPlan mapping at construction.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 17:03:00 PDT 2023


reames added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/RISCV/strided-accesses.ll:236
 ; NOSTRIDED-NEXT:    [[TMP5:%.*]] = add i64 [[INDEX]], 0
-; NOSTRIDED-NEXT:    [[TMP6:%.*]] = mul nuw nsw i64 [[TMP5]], [[STRIDE]]
+; NOSTRIDED-NEXT:    [[TMP6:%.*]] = mul nuw nsw i64 [[TMP5]], 1
 ; NOSTRIDED-NEXT:    [[TMP7:%.*]] = getelementptr i32, ptr [[P:%.*]], i64 [[TMP6]]
----------------
Completely unrelated to this, but it looks like we've got opportunity to fold these multiplies now.  Is this coming from an IRBuilder or a SCEVExpander?  If the former, we may just need to adjust the folder at construction.  (Assuming that eager folding doesn't interact badly with something inside LV/FPlan - which you'll have a much better idea than I do.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147783/new/

https://reviews.llvm.org/D147783



More information about the llvm-commits mailing list