[PATCH] D151273: [llvm-debuginfod][NFC] Switch to OptTable

Andres Villegas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 16:44:26 PDT 2023

avillega added a comment.

In D151273#4374565 <https://reviews.llvm.org/D151273#4374565>, @abrachet wrote:

> It would also be nice to update the bazel build. Technically we (because we don't work in google3) aren't required to keep the bazel build clean, though Google LLVM integrators will often see a commit was broken by a @ google.com address and ask that you fix it.
> In these cases, it might not be immediately obvious to the integrator how to fix this issues so it would certainly be courteous to fix it before landing. You can opt to join the bazel-build group https://reviews.llvm.org/project/profile/107/ which will add precommit checks to ensure the bazel build built cleanly.
> Though feel free to ignore

I couldn't find usages of llvm-debuginfod in the bazel files, I am assuming we currently do not build llvm-debuginfod with bazel given that it is not part of the default targets.

Comment at: llvm/tools/llvm-debuginfod/CMakeLists.txt:13
+  GSYMUtilOptsTableGen
abrachet wrote:
You are very right, I copy pasted it from another 

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list