[PATCH] D151273: [llvm-debuginfod][NFC] Switch to OptTable
Alex Brachet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 25 16:33:51 PDT 2023
abrachet added a comment.
It would also be nice to update the bazel build. Technically we (because we don't work in google3) aren't required to keep the bazel build clean, though Google LLVM integrators will often see a commit was broken by a @ google.com address and ask that you fix it.
In these cases, it might not be immediately obvious to the integrator how to fix this issues so it would certainly be courteous to fix it before landing. You can opt to join the bazel-build group https://reviews.llvm.org/project/profile/107/ which will add precommit checks to ensure the bazel build built cleanly.
Though feel free to ignore
================
Comment at: llvm/tools/llvm-debuginfod/CMakeLists.txt:13
+ DEPENDS
+ GSYMUtilOptsTableGen
)
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151273/new/
https://reviews.llvm.org/D151273
More information about the llvm-commits
mailing list