[PATCH] D151419: [DebugInfo][RemoveDIs] Eliminate some debug-intrinsics-affect-codegen errors

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 13:20:01 PDT 2023


dblaikie added a comment.

I know I'm a bit of a stickler for it, but my vote would be/I'd still prefer to see test cases for these. To demonstrate the code is exercised/correct, if nothing else. I realize the chance of regressing these fixes is probably relatively small, but I've certainly come across code before and been "I'm not sure why this is here, let's remove it and see what tests fail" in an effort to understand the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151419/new/

https://reviews.llvm.org/D151419



More information about the llvm-commits mailing list