[PATCH] D147172: [OpenMP][Flang][MLIR] Add lowering of TargetOp for host codegen

[Jeff Niu via Phabricator via llvm-commits]

Mogball added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/CMakeLists.txt:42
   MLIRTranslateLib
+  MLIROpenMPDialect
   )
----------------
This seems problematic. OpenMP dialect should not be a dependency on the generic LLVMIR export. It seems there is a layering issue here. You need to add your own LLVMIR export target with the OpenMP dialect registered.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147172/new/

https://reviews.llvm.org/D147172