[PATCH] D151211: [RISCV] Add test for small vector copies

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D151211#4365124 <https://reviews.llvm.org/D151211#4365124>, @luke wrote:

> In D151211#4364835 <https://reviews.llvm.org/D151211#4364835>, @reames wrote:
>
>> LGTM, with the following additions:
>>
>> 1. Add one test with volatile load
>> 2. Add one test with volatile store
>> 3. Add one test with atomic load or store
>
> Just to double check, it should be ok to perform scalarization on volatile/atomic stores right? That's what D150717 <https://reviews.llvm.org/D150717> already does

Generally, no.  If this is triggering for volatile memory ops, we should probably disable it.  There's no profit to be had here, and only risk.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151211/new/

https://reviews.llvm.org/D151211