[PATCH] D150360: [InstCombine] Optimize compares with multiple selects as operands

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Thanks, the implementation looks good to me. It would be good to also add some vector tests. In particular, we should have a test where the select result is a vector, and a test where both the select condition and select result is a vector. I think your code should already correctly handle these cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150360/new/

https://reviews.llvm.org/D150360