[PATCH] D151423: [MachineInstr] Implement new operand accessors all_defs and all_uses

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 06:51:16 PDT 2023


barannikov88 added a comment.

In D151423#4372071 <https://reviews.llvm.org/D151423#4372071>, @foad wrote:

> Here's a version with non-auto return types. I don't love it.

I'm fine with auto here, I think this is one of the cases where auto does more good than harm. Also, std::function is not cheap while a lambda can be inlined.
I asked because I thought it could be as simple as `iterator_range<const_mop_iterator>` above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151423/new/

https://reviews.llvm.org/D151423



More information about the llvm-commits mailing list