[PATCH] D151385: test-release.sh: Add support for cross-compiling

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

In D151385#4371979 <https://reviews.llvm.org/D151385#4371979>, @tstellar wrote:

> In D151385#4371866 <https://reviews.llvm.org/D151385#4371866>, @thieta wrote:
>
>> Looks fine to me. But I am unsure if we need to have the toolchain file checked into LLVM. Wouldn't that be up to the person cross-compiling? Going to be hard to assume stuff there?
>
> I wanted to add cross-compile support so that we could build 'official' binaries using GitHub actions for other arches besides x86_64.  For this scenario, I think it makes sense to have the toolchain file somewhere in tree, so that it is easy to reproduce the builds.  This specific file works with a container image that I created with all the necessary cross-libs, which I would also like to put in tree somewhere.

I guess this makes sense for that use. I wonder if we shouldn't start putting these files (all files related to release management) in a new top-level directory like `release` or `utils` instead of shoving them under the llvm directory. I think it might make more sense and be easier to understand that they are universal instead of just related to the llvm sub-project.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151385/new/

https://reviews.llvm.org/D151385