[PATCH] D151385: test-release.sh: Add support for cross-compiling

Thu May 25 05:56:41 PDT 2023

barannikov88 added a comment.

> But I am not convinced that we should have one of these files in the LLVM repo in the first place.

It could serve as an example. There is a bunch of CMake cache files in clang/cmake/caches and those are quite helpful in understanding how to build a toolchain.
It would be nice if this is mentioned in documentation, however.

================
Comment at: llvm/utils/release/aarch64-redhat-linux.cmake:5
+
+set(COMMON_COMPILE_FLAGS "-target ${TRIPLE} --sysroot=/usr/${TRIPLE}/")
+set(COMMON_LINK_FLAGS "-fuse-ld=lld")
----------------
thieta wrote:
> barannikov88 wrote:
> > How about splitting this into
> > CMAKE_SYSROOT and CMAKE_<LANG>_COMPILER_TARGET?
> > (This is what the CMake documentation suggests, I don't know if it works).
> > 
> Yeah that totally works and is the right way to handle that for sure.
> 
> Compared with my internal toolchain files this one seems very short and missing stuff. But I am not convinced that we should have one of these files in the LLVM repo in the first place.
It might serve as an example.
Maybe in different directory though 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151385/new/

https://reviews.llvm.org/D151385