[PATCH] D151423: [MachineInstr] Implement new operand accessors all_defs and all_uses

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 05:47:53 PDT 2023


foad added a comment.

> Q: What is the type of auto? Can it be spelled explicitly or is it unspellable?

I'm sure it //can// be spelled. See other methods that `use make_filter_range` like:

  iterator_range<filter_iterator<const MachineOperand *,
                                 std::function<bool(const MachineOperand &Op)>>>
  getDebugOperandsForReg(Register Reg) const {
    return MachineInstr::getDebugOperandsForReg<const MachineOperand,
                                                const MachineInstr>(this, Reg);
  }

But I'm not sure that spelling it out in that much detail is useful. Perhaps there is a simpler type that would work? I don't know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151423/new/

https://reviews.llvm.org/D151423



More information about the llvm-commits mailing list