[PATCH] D145218: PHI-def LIveInterval's LaneMask can be calculated by subranges LaneMask when Reg has SubRanges.

michael_zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 05:29:40 PDT 2023


Michael-Zhang-21 added a comment.

In D145218#4242579 <https://reviews.llvm.org/D145218#4242579>, @qcolombet wrote:

> I don't think this is correct.
> Here we are merging the main live-ranges, so if we set the join subrange flag we may not check the right thing. In particular, the `LaneBitmask` in this call is incorrect, unless I am mistaken, for a subrange check.

Thanks for your comments. I figured out that the SubRangeJoin can not be set true when Joining MainRanges.
In order to handle the problem, conflicting subrange with mainrange, I have modified the method of LaneMask calculation for PHI-def LiveRange. Details have been illustrated.

Hopeful to get some remarks of this change. Thx


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145218/new/

https://reviews.llvm.org/D145218



More information about the llvm-commits mailing list