[PATCH] D151416: [NFC][DAGCombiner]: Only consider nodes with no uses for pruning when forming initial worklist

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:181
+    /// which have no uses and all other nodes which would otherwise be added to
+    /// the worklist are already present in it during the initial formation.
     SmallSetVector<SDNode *, 32> PruningList;
----------------
I'd move this comment next to the initial population of the worklist.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1781
   for (SDNode &Node : DAG.allnodes())
-    AddToWorklist(&Node);
+    AddToWorklist(&Node, Node.use_empty());
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151416/new/

https://reviews.llvm.org/D151416