[PATCH] D150577: [CodeGen] Fix for MachineBasicBlock::rfindDebugLoc(instr_rend())

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 02:46:37 PDT 2023


bjope added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1489-1490
 DebugLoc MachineBasicBlock::findPrevDebugLoc(instr_iterator MBBI) {
-  if (MBBI == instr_begin()) return {};
+  if (MBBI == instr_begin())
+    return {};
   // Skip debug instructions, we don't want a DebugLoc from them.
----------------
dblaikie wrote:
> This looks like unrelated reformatting? Could you remove changes like this from this patch?
It's not unrelated to "Clean up code comments and code formatting related to the functions mentioned above.", but maybe you want all those things in a separate commit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150577/new/

https://reviews.llvm.org/D150577



More information about the llvm-commits mailing list