[PATCH] D146661: [BOLT] stale profile matching [part 2 out of 2]

[Amir Ayupov via Phabricator via llvm-commits]

Amir added a comment.

Please address a couple of nits. Will test internally, otherwise LG.
@maksfb – can you please take a look?



================
Comment at: bolt/lib/Profile/StaleProfileMatching.cpp:208
+
+/// Bla
+class StaleMatcher {
----------------
Remove or replace?


================
Comment at: bolt/lib/Profile/StaleProfileMatching.cpp:282-284
+    for (BinaryBasicBlock *PredBB : BB->predecessors()) {
+      Hash = hash_128_to_64(Hash, OpcodeHashes[PredBB->getIndex()]);
+    }
----------------
nit


================
Comment at: bolt/lib/Profile/StaleProfileMatching.cpp:384-386
+    if (MatchedBlock != nullptr) {
       MatchedBlocks[YamlBB.Index] = MatchedBlock;
     }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146661/new/

https://reviews.llvm.org/D146661