[PATCH] D151309: [RISCV][NFC] Simplify decoding code of disassembler

Wed May 24 20:48:10 PDT 2023

craig.topper added a comment.

In D151309#4370756 <https://reviews.llvm.org/D151309#4370756>, @craig.topper wrote:

> In D151309#4370646 <https://reviews.llvm.org/D151309#4370646>, @jrtc27 wrote:
>
>> Downstream we have a separate encoding mode that replaces some standard instructions with alternative ones; even if the order doesn't matter upstream, it would be preferable for us if the standard table was the last one not the first one.
>
> Well my thought doesn't work anyway because Zcmp and Zcmt are in a separate decoder namespace but the instructions they replace from C aren't in a namespace. So they have to be checked first. Same with Zfinx/Zdinx vs F/D.

Or maybe the predicate check in the DecoderTable fixes that?

Anyway it doesn't affect this patch just an observation to think about.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151309/new/

https://reviews.llvm.org/D151309